Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] Confusing drawer documentation #19868

Closed
smerriman18 opened this issue Feb 26, 2020 · 3 comments · Fixed by #19934
Closed

[Drawer] Confusing drawer documentation #19868

smerriman18 opened this issue Feb 26, 2020 · 3 comments · Fixed by #19934
Labels
component: app bar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@smerriman18
Copy link
Contributor

The <div className={classes.toolbar} /> component that leads to the styles component toolbar: theme.mixins.toolbar is really confusing because you have to go to a different page to figure out that the theme.mixins.toolbar is just a 54px margin. It would be more clear to just include a margin.

@smerriman18 smerriman18 changed the title Confusing drawer documentation [Drawer] Confusing drawer documentation Feb 26, 2020
@joshwooding
Copy link
Member

It might be slightly more confusing but it’s necessary to accommodate for the responsive toolbar styles. I think in this case correctness is better than simplicity, would it help if we added an explanation to the docs?

@smerriman18
Copy link
Contributor Author

That would be wonderful. I spend a lot of time trying to figure out why our content was underneath the app bar, but then discovered that all it needed was a margin. Thank you!

@joshwooding joshwooding added the docs Improvements or additions to the documentation label Feb 26, 2020
@mbrookes
Copy link
Member

@smerriman18 We'd be glad if you would like to document it. 👍

@oliviertassinari oliviertassinari added the component: app bar This is the name of the generic UI component, not the React module! label Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: app bar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants