Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] disableSelection does not disable all selections #20099

Closed
2 tasks done
tonyhallett opened this issue Mar 13, 2020 · 2 comments · Fixed by #20146
Closed
2 tasks done

[TreeView] disableSelection does not disable all selections #20099

tonyhallett opened this issue Mar 13, 2020 · 2 comments · Fixed by #20146
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!

Comments

@tonyhallett
Copy link
Contributor

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

  1. Only click is disabled
  2. Single select tree item when not selected will have aria-selected=false

Expected Behavior 🤔

  1. Expect all selection to be disabled.

  2. If the tree does not support multiple selection, aria-selected is set to true for the selected node and it is not present on any other node in the tree.

Steps to Reproduce 🕹

https://codesandbox.io/s/silly-knuth-yidwl

Steps:

  1. Focus Apples
  2. Press space - Apples is selected
  1. Click the button

Context 🔦

Trying to disable selection.
Expecting aria authoring practices
@oliviertassinari oliviertassinari added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Mar 15, 2020
@tonyhallett tonyhallett mentioned this issue Mar 16, 2020
Merged
1 task
@eps1lon eps1lon changed the title TreeView disableSelection does not disable all selections and incorrect aria-selected for single select TreeView disableSelection does not disable all selections Mar 22, 2020
@eps1lon eps1lon changed the title TreeView disableSelection does not disable all selections [TreeView] disableSelection does not disable all selections Mar 22, 2020
@eps1lon
Copy link
Member

eps1lon commented Mar 22, 2020

"incorrect aria-selected for single select" was fixed in #20102

@eps1lon
Copy link
Member

eps1lon commented Mar 25, 2020

Closed in #20146. GitHub decided to ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TreeView] Disable all selection when disableSelection
3 participants
@oliviertassinari @tonyhallett @eps1lon