Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labelPosition documentation mismatch #2012

Closed
denis-sokolov opened this issue Oct 30, 2015 · 6 comments · Fixed by #2014
Closed

labelPosition documentation mismatch #2012

denis-sokolov opened this issue Oct 30, 2015 · 6 comments · Fixed by #2014
Labels
component: button This is the name of the generic UI component, not the React module!

Comments

@denis-sokolov
Copy link

The documentation claims that RaisedButton has a labelPosition property, while a FlatButton does not. In reality, it is the opposite.

@oliviertassinari
Copy link
Member

Your are right, the docs was added to the wrong component!
Do you want to submit a PR to move it?

@denis-sokolov
Copy link
Author

I tried and did not figure out how to do that.
Besides, the proper fix would be to add the option on all buttons, instead of fixing the documentation.

@oliviertassinari
Copy link
Member

the proper fix would be to add the option on all buttons, instead of fixing the documentation

I agree, but having a wrong document is event worse.

I will have a look then.

@denis-sokolov
Copy link
Author

Thanks!

@oliviertassinari
Copy link
Member

@denis-sokolov Can you have a look at #2014?

@denis-sokolov
Copy link
Author

Closed by #2014.

@zannager zannager added the component: button This is the name of the generic UI component, not the React module! label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants