-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Update to match the specification #20153
Comments
I fixed this problem by changing constrastText to "needed color" pallete theme |
@Ghost180195 Thanks for raising this issue. At first glance, it seems that we will need to update the style of the component: https://material.io/components/sliders/#anatomy https://www.google.com/flights We should be able to move from 3 to 1 or 2 elements. In any case, it's likely a breaking change, so something to plan for v5. In the meantime, I would propose that we make the diff --git a/packages/material-ui/src/Slider/ValueLabel.js b/packages/material-ui/src/Slider/ValueLabel.js
index e2f21ec0d..6b57749d5 100644
--- a/packages/material-ui/src/Slider/ValueLabel.js
+++ b/packages/material-ui/src/Slider/ValueLabel.js
@@ -69,4 +69,4 @@ function ValueLabel(props) {
);
}
-export default withStyles(styles, { name: 'PrivateValueLabel' })(ValueLabel);
+export default withStyles(styles, { name: 'MuiSliderValueLabel' })(ValueLabel); @Ghost180195 Do you want to work on the problem? :) |
The latest design of the slider I could find on Google's product:
Any other idea where we could find a slider to benchmark? |
More sources to benchmark:
|
I need to change text in label, not background color
const theme = createMuiTheme({ overrides:{ MuiSlider: { valueLabel: { color: 'black', }, } }
Current Behavior 😯
It changes only tbackground color, not text color
Expected Behavior 🤔
It should change only text color, not background color
The text was updated successfully, but these errors were encountered: