@material-ui/core 4.9.11 cannot be compiled by shadow-cljs.

[veer66]

@material-ui/core 4.9.11 cannot be compiled by shadow-cljs since it has multiple versions of dom-types.

$ npm list | grep dom-helpers
| | +-- dom-helpers@3.4.0
|   +-- dom-helpers@5.1.4

Current Behavior 😯

$ npx shadow-cljs compile webapp
shadow-cljs - config: /work/shadow-cljs.edn
NPM dependency "react" has installed version "^16.12.0"
"16.8.6" was required by jar:file:/home/node/.m2/repository/re-frame/re-frame/0.10.9/re-frame-0.10.9.jar!/deps.cljs
NPM dependency "react-dom" has installed version "^16.12.0"
"16.8.6" was required by jar:file:/home/node/.m2/repository/re-frame/re-frame/0.10.9/re-frame-0.10.9.jar!/deps.cljs
[:webapp] Compiling ...
The required JS dependency "dom-helpers/addClass" is not available, it was required by "node_modules/react-transition-group/cjs/CSSTransition.js".

Search in:
	/work/node_modules
You probably need to run:
  npm install dom-helpers/addClass

See: https://shadow-cljs.github.io/docs/UsersGuide.html#npm-install

Expected Behavior 🤔

$ npx shadow-cljs compile webapp
shadow-cljs - config: /work/shadow-cljs.edn
NPM dependency "react" has installed version "^16.12.0"
"16.8.6" was required by jar:file:/home/node/.m2/repository/re-frame/re-frame/0.10.9/re-frame-0.10.9.jar!/deps.cljs
NPM dependency "react-dom" has installed version "^16.12.0"
"16.8.6" was required by jar:file:/home/node/.m2/repository/re-frame/re-frame/0.10.9/re-frame-0.10.9.jar!/deps.cljs
[:webapp] Compiling ...
npm package "@material-ui/react-transition-group" expected version "dom-helpers@^3.4.0" but "5.1.4" is installed.
[:webapp] Build completed. (567 files, 1 compiled, 0 warnings, 6.93s)

Steps to Reproduce 🕹

Steps:

1. git clone -b issue1 https://github.com/veer66/shadow1.git shadow1-issue1
2. cd shadow1-issue1
3. sudo docker run -it --rm -u $(ls -n README.md | awk '{ print $3 }') -v $(pwd):/work -e HOME=/work -w /work veer66/node-jdk bash
4. npm install
5. npx shadow-cljs compile webapp

Context 🔦

I want to use the latest version of Material-UI with ClojureScript.

Your Environment 🌎

Tech	Version
Material-UI	v4.9.11
React	v16.12.0
shadow-cljs	v2.8.98

[david]

I believe the problem has to do with @material-ui/react-transition-group, which is using version 3.4.0 of dom-helpers. I looked and it seems that repo is about 50 commits behind upstream react-transition-group.

I'd be happy to open a PR against @material-ui/react-transition-group if anyone would be willing to provide some guidance as to what needs to be done.

[eps1lon]

I'd be happy to open a PR against @material-ui/react-transition-group if anyone would be willing to provide some guidance as to what needs to be done.

You'd need sync it with the latest relase of react-transition-group.