Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color variables to input component #212

Closed
0x80 opened this issue Jan 8, 2015 · 2 comments
Closed

Add color variables to input component #212

0x80 opened this issue Jan 8, 2015 · 2 comments
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.

Comments

@0x80
Copy link

0x80 commented Jan 8, 2015

I noticed that "blue" is hardcoded into a lot of places in the input component. I've replaced it with "@input-color" and set it to "@accent-1-color". Probably something similar could be done with the "grey" and "red" error colors.

I could make a pull request if you agree with the variable naming.

Slightly related question but really about using Less; is it possible to address only a specific input instance? For example I would like to set @input-width for a search field that's part of a menu/sidebar without affecting the width of inputs I use in other locations. Or would this have to be a component property for it to work?

@0x80 0x80 closed this as completed Jan 8, 2015
@0x80 0x80 reopened this Jan 8, 2015
@hai-cea
Copy link
Member

hai-cea commented Jan 22, 2015

@0x80 Please checkout the TextField component that was just added. It uses the primary-1-color as the underline bar. You also be able to set the width through css. b607a57

@hai-cea hai-cea closed this as completed Jan 22, 2015
@0x80
Copy link
Author

0x80 commented Jan 22, 2015

@hai-cea That's awesome, thanks!

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

No branches or pull requests

4 participants