-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add same Dialog event props to Drawer component #21472
Labels
duplicate
This issue or pull request already exists
Comments
yanickrochon
added
the
status: waiting for maintainer
These issues haven't been looked at yet by a maintainer
label
Jun 16, 2020
oliviertassinari
added
duplicate
This issue or pull request already exists
and removed
status: waiting for maintainer
These issues haven't been looked at yet by a maintainer
labels
Jun 16, 2020
Duplicate of #18288 |
Wow! |
Use the |
You mean |
+1 |
That expose by d.ts, but It actual not working |
@s97712 It depends on the variant of the drawer you use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expose the same props in
Drawer
as forDialog
, namely :onEnter
onEntered
onEntering
onExit
onExited
onExiting
When a drawer is closing (
onExiting
) and then closed (onExited
), I currently have to guess these states because the events are not currently available.Summary 💡
See
Dialog
Motivation 🔦
A Drawer and a Dialog both accomplish similar goals, but with different layout styles. However, the functionality of a
Dialog
is far more complete than that of aDrawer
. For example, when a drawer is opened, an interface could "pause" whatever it's doing until the drawer is completely closed. Currently, this cannot be done with the current implementation.The text was updated successfully, but these errors were encountered: