Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add same Dialog event props to Drawer component #21472

Closed
1 task done
yanickrochon opened this issue Jun 16, 2020 · 7 comments
Closed
1 task done

Add same Dialog event props to Drawer component #21472

yanickrochon opened this issue Jun 16, 2020 · 7 comments
Labels
duplicate This issue or pull request already exists

Comments

@yanickrochon
Copy link

Expose the same props in Drawer as for Dialog, namely :

  • onEnter
  • onEntered
  • onEntering
  • onExit
  • onExited
  • onExiting

When a drawer is closing (onExiting) and then closed (onExited), I currently have to guess these states because the events are not currently available.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

See Dialog

Motivation 🔦

A Drawer and a Dialog both accomplish similar goals, but with different layout styles. However, the functionality of a Dialog is far more complete than that of a Drawer. For example, when a drawer is opened, an interface could "pause" whatever it's doing until the drawer is completely closed. Currently, this cannot be done with the current implementation.

@yanickrochon yanickrochon added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 16, 2020
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 16, 2020
@oliviertassinari
Copy link
Member

Duplicate of #18288

@oliviertassinari oliviertassinari marked this as a duplicate of #18288 Jun 16, 2020
@yanickrochon
Copy link
Author

Wow! Drawer is not even mentioned in that "related" issue!

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 16, 2020

Use the ModalProps.

@yanickrochon
Copy link
Author

You mean Slider, because the onExited event does not exist on Modal, but on the transition. My point is, Dialog exposes these props, but not Drawer.

@s97712
Copy link

s97712 commented Jun 17, 2020

+1

@s97712
Copy link

s97712 commented Jun 17, 2020

That expose by d.ts, but It actual not working

@oliviertassinari
Copy link
Member

@s97712 It depends on the variant of the drawer you use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants