-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popover] Height and width animations are not working as expected due to top and left properties #21561
Comments
We plan to replace the positioning logic of the Popover component with the Popper one. It should address this problem at the same time. |
Great. Thanks. |
Any updates on this issue? |
Hi! Any chance of fixing this in the near future? |
@oliviertassinari |
Popover always positions itself using top and left properties. But if we change the height or width of the content, popover always grow vertically downwards in case of height or towards the right in case of width.
Current Behavior 😯
Expected Behavior 🤔
We should be able to control the properties using which popover should position itself. Depending on the usecase, user should be able to choose a combination of top/bottom and right/left.
Steps to Reproduce 🕹
You can see the issue here.
https://codesandbox.io/s/twilight-architecture-dqn2n?file=/src/App.js
Steps:
The popover grows downwards covering the anchor element. And repositions itself when the Shrink button is clicked.
We can use a prop to supply what properties the popover should use. I would be happy to raise a PR for this.
Context 🔦
Your Environment 🌎
The text was updated successfully, but these errors were encountered: