Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hidden/Grid] Custom breakpoint support #21589

Closed
DriesDeBackker opened this issue Jun 27, 2020 · 7 comments
Closed

[Hidden/Grid] Custom breakpoint support #21589

DriesDeBackker opened this issue Jun 27, 2020 · 7 comments
Labels
component: Grid The React component. component: Hidden The React component. new feature New feature or request out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@DriesDeBackker
Copy link

Currently, Material-UI supports custom breakpoints , but this support seems to be lacking in some components, in particular in. Hidden. The breakpoints used in this component are fixed and come with an -Up and -Down prop. I suggest that Hidden switches to a single 'up' and 'down' prop for all breakpoints, which can for instance be set as follows up="xs" down="xxs lg" (with xxs a custom breakpoint defined in the theme)

@DriesDeBackker DriesDeBackker added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 27, 2020
@eps1lon eps1lon added component: Hidden The React component. new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 27, 2020
@eps1lon
Copy link
Member

eps1lon commented Jun 27, 2020

I think we're missing the same feature for the Grid component. @oliviertassinari wanted to implement this at some point if I recall correctly.

@oliviertassinari
Copy link
Member

@eps1lon Agree, I think that we should support custom breakpoints anywhere we can. However, It depends on the outcome of #19704.

@oliviertassinari oliviertassinari changed the title <Hidden> custom breakpoint support [Hidden] Custom breakpoint support Aug 22, 2020
@oliviertassinari oliviertassinari changed the title [Hidden] Custom breakpoint support [Hidden/Grid] Custom breakpoint support Sep 30, 2020
@oliviertassinari oliviertassinari added the component: Grid The React component. label Sep 30, 2020
@SassNinja
Copy link
Contributor

@oliviertassinari any update on this?

The issue you've linked refers to the Hidden component.
However what I really need (and what is mentioned in this issue, too) is full custom breakpoint support for the Grid component.

When I create something like this

const theme = createMuiTheme({
  breakpoints: {
    keys: ['small', 'medium', 'large'],
    values: {
      small: o,
      medium: 640,
      large: 1025
    }
  }
});

I'd like to use this everywhere e.g.

<Grid small={12} large={6} item>

@oliviertassinari
Copy link
Member

@SassNinja No direct progress yet but we have almost solved the blocker on the style engine (in progress JSS -> emotion/sc transition).

@oliviertassinari
Copy link
Member

I'm closing for #19704

@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Mar 19, 2021
@nicobatalla
Copy link

Any progress on this? This seems not supported as of today.

@marcelino-borges
Copy link

Man, disapointing... lol
If I'm able to override the breakpoints (key and/or values), it's pretty obious that I can use my custom breakpoints in a .
But I caaaan't!! hahahha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. component: Hidden The React component. new feature New feature or request out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Development

No branches or pull requests

6 participants