Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hidden] css differs from js implementation #21624

Closed
ohlr opened this issue Jun 30, 2020 · 1 comment
Closed

[Hidden] css differs from js implementation #21624

ohlr opened this issue Jun 30, 2020 · 1 comment
Labels
component: Hidden The React component.

Comments

@ohlr
Copy link
Contributor

ohlr commented Jun 30, 2020

[Hidden] css differs from js implementation with respect to Grid.

https://codesandbox.io/s/friendly-chatelet-hg2ne?file=/src/Demo.js

(you need to reduce the width of the window to see the buttons)
The js Hidden is full width. The css Hidden is reduced width.

I have seen you want to remove Hidden within v5. Maybe you should provide reference examples how to make implementations equivalent with respect to Grid.
Here only js implementation is demonstrated.

@ohlr ohlr added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 30, 2020
@oliviertassinari oliviertassinari added component: Hidden The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 30, 2020
@oliviertassinari
Copy link
Member

@ohlr This is expected, one has an extra div element (CSS) to make it work. Add a div to the js implementation, it will be equivalent.

Closing for #19704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Hidden The React component.
Projects
None yet
Development

No branches or pull requests

2 participants