Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripples fire on drag/swipe on iOS and Android #2165

Closed
gmaclennan opened this issue Nov 14, 2015 · 3 comments · Fixed by #3407
Closed

Ripples fire on drag/swipe on iOS and Android #2165

gmaclennan opened this issue Nov 14, 2015 · 3 comments · Fixed by #3407
Labels
bug 🐛 Something doesn't work

Comments

@gmaclennan
Copy link

When scrolling a ListItem or Button on iOS or Android touch ripples fire wherever I touch to drag / scroll the screen. This gives a pretty bad user experience while scrolling a list.

Using Chrome 46.0.2490.76 on Android 4.4.4 and Safari on iOS 9.1

Is there a way to disable ripple effects altogether?

@svk31
Copy link

svk31 commented Nov 17, 2015

I added Fastclick to my project to remove the 300ms click delay. Besides making the iOS version feel a LOT faster, it had the added benefit of removing the double ripples. You could try that out.

https://github.com/ftlabs/fastclick

@owencm
Copy link
Contributor

owencm commented Feb 19, 2016

The ripples in lists when scrolling have always bothered me too, and don't match material implementations on Android so I think it's fair to say this is a bug.

This also causes scroll performance issues since we're then listening to touch events while scrolling.

I suggest we delay the ripple by some milliseconds and then don't trigger the ripple and remove event listeners if the user appears to be scrolling. Further if we detect scrolling during ripples we should abort, as is done on Android.

I think this will improve UX but also improve scrolling perf dramatically.

I'd like to send a PR for this if I get time, but if somebody else is interested then don't wait for me!

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Feb 19, 2016
@owencm
Copy link
Contributor

owencm commented Feb 21, 2016

FYI I have submitted PR #3407 to fix this issue. Will wait to see the feedback, but hopefully can get this fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants