Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListItem] Using button prop forces an invalid nesting of list items #21712

Closed
2 tasks done
heidi-jungel opened this issue Jul 8, 2020 · 2 comments
Closed
2 tasks done
Labels
duplicate This issue or pull request already exists

Comments

@heidi-jungel
Copy link

When using the component passing a prop, it produces invalid nesting as it converts this from an <li> to a <div> with a button role.

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

This causes a lot of problems for users of assistive technologies.
Ideally, it should be a single default button (to hold keyboard internation) nested in a singleli element.

Expected Behavior 🤔

Should be
<li...><button....>...

Steps to Reproduce 🕹

Steps:

Context 🔦

Your Environment 🌎

Tech Version
Material-UI v4.?.?
React
Browser
TypeScript
etc.
@heidi-jungel heidi-jungel added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 8, 2020
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 8, 2020
@oliviertassinari
Copy link
Member

Duplicate #13597

@oliviertassinari
Copy link
Member

I think that we should move forward with the proposal of @eps1lon in #13597 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants