Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.13.4] Multiple warnings for DatePicker and SelectField #2267

Closed
jgoux opened this issue Nov 25, 2015 · 6 comments
Closed

[v0.13.4] Multiple warnings for DatePicker and SelectField #2267

jgoux opened this issue Nov 25, 2015 · 6 comments
Labels
component: pickers This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module!

Comments

@jgoux
Copy link
Contributor

jgoux commented Nov 25, 2015

Hello,
since I updated to v0.13.4 (from v0.13.3), I have this warnings :

Warning: Failed propType: Invalid prop `onDismiss` of type `boolean` supplied to `Dialog`, expected `function`. Check the render method of `DatePickerDialog`.

Warning: Failed propType: Invalid prop `onShow` of type `boolean` supplied to `Dialog`, expected `function`. Check the render method of `DatePickerDialog`.

Warning: Failed propType: Invalid prop `value` of type `string` supplied to `DropDownMenu`, expected `object`. Check the render method of `SelectField`.
@oliviertassinari
Copy link
Member

Thanks for reporting this warnings. I confirm. We have added a lot of missing PropType, some of them are wrong.

@petrmazanec
Copy link

Hello,
I have similar warnings for prop value of RadioButton - now expecting boolean, but it should really be string to go with RadioButtonGroup.

@ajsharp
Copy link

ajsharp commented Dec 1, 2015

Is the issue wrong arguments being passed in, or wrong definitions in the component being rendered? Would you accept a pull request that fixes the issue?

@oliviertassinari
Copy link
Member

The issue is linked to wrong PropType values declared in the components. The issue should be partually fixed on the master branch now.

@alitaheri
Copy link
Member

@oliviertassinari Can we close this now?

@oliviertassinari
Copy link
Member

@zannager zannager added component: select This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

6 participants