Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Links vs Buttons #23444

Open
eps1lon opened this issue Nov 8, 2020 · 2 comments
Open

[RFC] Links vs Buttons #23444

eps1lon opened this issue Nov 8, 2020 · 2 comments
Labels
discussion docs Improvements or additions to the documentation RFC Request For Comments umbrella For grouping multiple issues to provide a holistic view

Comments

@eps1lon
Copy link
Member

eps1lon commented Nov 8, 2020

Opening this to be filled with arguments why or why not buttons should look like anchors.

We accidentally merged a change that enforced the distinction partially. Any decision we do make should be applied consistently. The button vs anchor discussion is already hard to follow. We shouldn't make it more complicated by applying different stances throughout our docs.

#22780 enforced different visuals for links in the nav menu but didn't make a proper argument why.

@eps1lon eps1lon added docs Improvements or additions to the documentation umbrella For grouping multiple issues to provide a holistic view labels Nov 8, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 8, 2020

#22780 enforced different visuals for links in the nav menu

Regarding #22780, the motivation was to make it easier to understand where a user is in the navigation. Am I on an intermediary level I can drill down into or am. I on a leaf I can open? The motivation is identical to the different visual a folder explore has in different OS, e.g. macOS.

Capture d’écran 2020-11-08 à 12 42 51

So I think that it's more a concern for the tree view.

It also coincides with the introduction of more layers of nesting in the documentation: #22692 that makes navigation disorientation's problem now more relevant than before.

Capture d’écran 2020-11-08 à 12 53 04

components > lab > date/time > date picker


Any decision we do make should be applied consistently.

Regarding the documentation, considering the direction is to support multiple themes and that we are redoing the branding to be non-material design-based, one option would be to update the whole design of the documentation to move away from material design too, only keeping Material Design for the Material Design demos of this specific theme.


Links vs Buttons

Regarding button that can look like links and the other way around, I think that we need to support both, end-users are used to seeing both. For instance in GitHub:

Capture d’écran 2020-11-08 à 12 35 10

Capture d’écran 2020-11-08 à 12 39 39

@samuelsycamore
Copy link
Contributor

Is this issue still relevant in late 2023? It's not clear to me what the discussion is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion docs Improvements or additions to the documentation RFC Request For Comments umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

No branches or pull requests

3 participants