Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TouchRipple: configurable maximum ripple size #24310

Closed
1 task done
aeharding opened this issue Jan 8, 2021 · 2 comments
Closed
1 task done

TouchRipple: configurable maximum ripple size #24310

aeharding opened this issue Jan 8, 2021 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@aeharding
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Proposal:

  • TouchRipple to expose property maxSize on TouchRippleProps. (Accessed by the developer via TouchRippleProps on ButtonBase, and potentially a dedicated parameter on ButtonBase like centerRipple has.)
  • Consider defaulting a maxSize.

Examples 🌈

Here's an example of how fast and jarring the animation can appear on a very large button area, since the ripple propagates across the entire surface:

https://codesandbox.io/s/material-demo-forked-kjfwl

Motivation 🔦

maxSize would allow the ripple animation to not be forced to ripple over the entire button surface within X ms (which appears too quick/jarring on the example above).

My main use case is an empty state where the user can click anywhere on the empty state to proceed.

@aeharding aeharding added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 8, 2021
@oliviertassinari
Copy link
Member

@aeharding I think that it's a duplicate of #19664. We can solve the problem at its root.

@aeharding
Copy link
Author

Sounds great @oliviertassinari. I'll subscribe to that issue :)

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants