-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snackbar] Shouldn't be light in dark mode #24438
Comments
@manufont I'm tempted to say that we can ignore your issue because if the action is disabled, it shouldn't be shown in the first place in a toast. Now, having a closer look at the Material Design guidelines, I believe the snackbar should be dark, not light. At least; it's the behavior I could find on:
This would also solve the contrast issue between the action button color and background. |
Can I work on this? |
@ManuFront you could provide a light theme to the button https://codesandbox.io/s/material-ui-issue-forked-ucdv8?file=/src/Demo.js but it would only likely hide the root issue. I would encourage to either customize the button or to not render a disabled one inside the snackbar (what's the use case if it can't be interacted with)? https://material.io/design/color/dark-theme.html#ui-application |
Current Behavior 😯
In dark mode, snackbar have a white background and a dark color. However, snackbar actions seems to have the same style as if they were not part of a snackbar. This means that disabled actions appears white on a white background.
Expected Behavior 🤔
Disabled snackbar actions should be visible on dark mode.
Steps to Reproduce 🕹
https://codesandbox.io/s/material-ui-issue-forked-9zlxc
Steps:
The text was updated successfully, but these errors were encountered: