Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snackbar] Shouldn't be light in dark mode #24438

Closed
2 tasks done
manufont opened this issue Jan 15, 2021 · 3 comments
Closed
2 tasks done

[Snackbar] Shouldn't be light in dark mode #24438

manufont opened this issue Jan 15, 2021 · 3 comments
Labels
component: snackbar This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Milestone

Comments

@manufont
Copy link

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

In dark mode, snackbar have a white background and a dark color. However, snackbar actions seems to have the same style as if they were not part of a snackbar. This means that disabled actions appears white on a white background.

image

Expected Behavior 🤔

Disabled snackbar actions should be visible on dark mode.

Steps to Reproduce 🕹

https://codesandbox.io/s/material-ui-issue-forked-9zlxc

Steps:

  1. Configure a custom theme with dark mode enabled
  2. Display a Snackbar with a disabled action
@manufont manufont added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 15, 2021
@oliviertassinari oliviertassinari changed the title Disabled snackbar actions are hidden in dark mode [Snackbar] Shouldn't be light in dark mode Jan 16, 2021
@oliviertassinari oliviertassinari added component: snackbar This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 16, 2021

@manufont I'm tempted to say that we can ignore your issue because if the action is disabled, it shouldn't be shown in the first place in a toast.

Now, having a closer look at the Material Design guidelines, I believe the snackbar should be dark, not light. At least; it's the behavior I could find on:

  • YouTube
  • Google Keep

This would also solve the contrast issue between the action button color and background.

@oliviertassinari oliviertassinari modified the milestones: v5, v5-beta Jan 16, 2021
@oliviertassinari oliviertassinari added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Jan 16, 2021
@oliviertassinari oliviertassinari modified the milestones: v5-beta, v5 Jan 27, 2021
@Renfrew
Copy link
Contributor

Renfrew commented Jan 30, 2021

Can I work on this?

@oliviertassinari oliviertassinari added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) and removed ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Jan 31, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 31, 2021

@ManuFront you could provide a light theme to the button https://codesandbox.io/s/material-ui-issue-forked-ucdv8?file=/src/Demo.js but it would only likely hide the root issue. I would encourage to either customize the button or to not render a disabled one inside the snackbar (what's the use case if it can't be interacted with)?

Screenshot 2021-04-20 at 17 13 07

https://material.io/design/color/dark-theme.html#ui-application

@oliviertassinari oliviertassinari removed the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants