Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text field underline when selected has two separate lines drawn #2448

Closed
justjacksonn opened this issue Dec 9, 2015 · 7 comments · Fixed by #2476
Closed

Text field underline when selected has two separate lines drawn #2448

justjacksonn opened this issue Dec 9, 2015 · 7 comments · Fixed by #2476
Labels
bug 🐛 Something doesn't work

Comments

@justjacksonn
Copy link

screen shot 2015-12-09 at 7 59 30 am

Additionally..sometimes it seems to work fine, other times not.. I have not been able to pinpoint what/why it sometimes works and sometimes does not.

@alitaheri
Copy link
Member

That underline will have to be made into it's own component. I had way to many issues with it. There are actually 2 lines. and they inherit some styles from one another. This is indeed a bug that needs a re-design. don't try so hard to make a reproducable example. We'll have to make some major changes regarding this.

@newoga
Copy link
Contributor

newoga commented Dec 16, 2015

@justjacksonn We recently merged a reimplementation of how underline works and is styled. The new implementation still relies on two lines, but the code has been refactored and simplified. Would you be able to confirm whether this was fixed for you with the latest in master? 😄

@justjacksonn
Copy link
Author

I would love to verify, but I gotta be honest.. I am horrible at figuring out how to get the latest from a given branch and then using it as if I npm install --save. I have thus far waited for the fixes to be pushed, if you can enlighten me on that step, I'd be happy to grab the latest and give it a whirl.

@alitaheri
Copy link
Member

@justjacksonn What is the platform you're working on? is it linux?

@newoga
Copy link
Contributor

newoga commented Dec 16, 2015

Node.js has a feature where you can add a git url as a dependency so where you have the version you can try git://github.com/callemall/material-ui.git to pull the latest in master. I don't use the feature often but it's documented and should work.

Thanks much for following up @justjacksonn

Note: According to the docs, specifying just callemall/material-ui should work too.

@justjacksonn
Copy link
Author

Well Mac and/or Linux depending on the day of the week. :D

@alitaheri
Copy link
Member

@newoga That won't work since it will not trigger a build. it will be VERY hard to get that to work 😁

@justjacksonn Good, then you need git and node. do the following in command line:

  1. git clone https://github.com/callemall/material-ui.git
  2. cd material-ui
  3. npm install
  4. cd docs
  5. npm install
  6. npm start
  7. open browser and go to http://localhost:3000

This is if you wanna take a look at the docs.

If you want to see the effect of the newest changes in your project follow these steps instead:

  1. Add callemall/material-ui instead of ^0.14.0-rc2 as material-ui version to your package.json.
  2. npm install
  3. cd node_modules/material-ui
  4. npm install
  5. npm run build
  6. this is a hack you have to perform to get this to work: remove react from node_modules folder WITHIN the node_modules/material-ui folder.
  7. You should have the latest changes for your project.

ping me again if this fails at any stage with the error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants