-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text field underline when selected has two separate lines drawn #2448
Comments
That underline will have to be made into it's own component. I had way to many issues with it. There are actually 2 lines. and they inherit some styles from one another. This is indeed a bug that needs a re-design. don't try so hard to make a reproducable example. We'll have to make some major changes regarding this. |
@justjacksonn We recently merged a reimplementation of how underline works and is styled. The new implementation still relies on two lines, but the code has been refactored and simplified. Would you be able to confirm whether this was fixed for you with the latest in master? 😄 |
I would love to verify, but I gotta be honest.. I am horrible at figuring out how to get the latest from a given branch and then using it as if I npm install --save. I have thus far waited for the fixes to be pushed, if you can enlighten me on that step, I'd be happy to grab the latest and give it a whirl. |
@justjacksonn What is the platform you're working on? is it linux? |
Node.js has a feature where you can add a git url as a dependency so where you have the version you can try Thanks much for following up @justjacksonn Note: According to the docs, specifying just |
Well Mac and/or Linux depending on the day of the week. :D |
@newoga That won't work since it will not trigger a build. it will be VERY hard to get that to work 😁 @justjacksonn Good, then you need git and node. do the following in command line:
This is if you wanna take a look at the docs. If you want to see the effect of the newest changes in your project follow these steps instead:
ping me again if this fails at any stage with the error messages. |
Additionally..sometimes it seems to work fine, other times not.. I have not been able to pinpoint what/why it sometimes works and sometimes does not.
The text was updated successfully, but these errors were encountered: