Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Rename getOptionSelected to optionEqualValue #24855

Closed
1 task done
oliviertassinari opened this issue Feb 10, 2021 · 3 comments · Fixed by #26173
Closed
1 task done

[Autocomplete] Rename getOptionSelected to optionEqualValue #24855

oliviertassinari opened this issue Feb 10, 2021 · 3 comments · Fixed by #26173
Labels
breaking change component: autocomplete This is the name of the generic UI component, not the React module!
Milestone
v5-beta

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 10, 2021 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

In the v5 RFC issue, we have a mention of doing this change but no dedicated issue. Developers can get a better idea of the motivation for the change by searching for getOptionSelected in the closed issues. Or #19595 (comment)

Motivation

Make the API more intuitive, the mental model can be improved.

On a related note, a few developers have been asking for the same feature with the Select: #24201
@oliviertassinari oliviertassinari added breaking change component: autocomplete This is the name of the generic UI component, not the React module! labels Feb 10, 2021
@oliviertassinari oliviertassinari added this to the v5-beta milestone Feb 10, 2021
@eps1lon
Copy link
Member

eps1lon commented Feb 12, 2021

Would recommend using optionEqualsValue or isOptionEqualToValue to use natural language (just like React has arePropsEqual).

@oliviertassinari
Copy link
Member Author

@mbrookes a preference?

@Faithfinder

This comment has been minimized.

Sign in to view
This was referenced May 6, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging a pull request may close this issue.

[Autocomplete] Rename getOptionSelected to isOptionEqualToValue m4theushw/material-ui
3 participants
@oliviertassinari @eps1lon @Faithfinder