Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migration guide from v4 to next should mention the color difference of Paper and related components in the dark mode #26163

Closed
2 tasks done
ti1024 opened this issue May 6, 2021 · 1 comment
Labels
docs Improvements or additions to the documentation v5.x migration

Comments

@ti1024
Copy link

ti1024 commented May 6, 2021

In Material-UI next, Paper surface color becomes brighter in the dark mode by default (cf. https://next.material-ui.com/components/paper/#elevation, #18309, and note that the default value of elevation is 1). This also affects other components based on Paper such as Drawer. It is better if these changes are documented in the migration guide (https://next.material-ui.com/guides/migration-v4/).

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

I do not think that https://next.material-ui.com/guides/migration-v4/ mentions the color difference of Paper or Drawer (or any other components that are based on Paper) in the dark mode.

Expected Behavior 🤔

https://next.material-ui.com/guides/migration-v4/ should mention the color difference of Paper and Drawer (and other components that are based on Paper) in the dark mode.

@ti1024 ti1024 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 6, 2021
@ti1024 ti1024 changed the title [docs] Migration guide from v4 to next should mention the color difference of Paper in the dark mode [docs] Migration guide from v4 to next should mention the color difference of Paper and related components in the dark mode May 6, 2021
@oliviertassinari
Copy link
Member

It was recently added, not released yet: https://next--material-ui.netlify.app/guides/migration-v4/#paper.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation v5.x migration and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation v5.x migration
Projects
None yet
Development

No branches or pull requests

2 participants