Not that friendly on phones, is this a work in progress?

[ffxsam]

I noticed some things are a bit broken on phones. For instance, the date picker goes off-screen on the iPhone 5s. The Slider component is very difficult to use due to being such a small handle (on any touch device). Are these things you guys need help with?

[alitaheri]

Well this library is still under heavy development. Any help is appreciated 😅 😅

[alitaheri]

the date picker goes off-screen on the iPhone 5s

This is actually related to dialog. It's top offset calculation is limited.

[ffxsam]

Haha.. I figured. :) I'm glad to help whenever I have free time! Is there some documentation to help developers get on board with how the code is structured? All the JavaScript styles kinda made my head spin a bit..

[ffxsam]

BTW, I made a pull request:
#2946

As you can see, I ran into some really weird behavior with styles. Maybe someone can take a look when they can.

[alitaheri]

We are also working on a contribution guild 😅 😅

We are also doing our best to improve the quality of the source code so contributes won't get lost in it. It took me a long time to understand some parts. and some parts are still very unknown to me. So I understand 😆

Your help is appreciated. thank you 👍 👍

[mbrookes]

Hey @ffxsam, good to see you here! (We've chatted on the Meteor gitter). Yes, mobile support, and responsiveness in general are lacking, so anything you can do to help will be greatly appreciated!

[ffxsam]

Happy to help when I can!

One (hopefully) quick favor: could someone could tell me how to set up my environment so that in all my projects, package.json points to a local copy of Material UI rather than the one in the NPM registry?

I just tried this:

$ npm i --save /path/to/my/fork

I thought that would work, but it didn't, and my app yields this error in the Chrome console:

Uncaught Error: Cannot find module 'material-ui/lib/styles/theme-manager'

[ffxsam]

Ah never mind, I was doing something wrong.

The last question I have: if I make updates in ~/GitHub/material-ui on my fork, how do I tell my projects that use that package to pull in any updates? npm update didn't seem to do anything.

[halhenke]

npm link is probably what you are looking for.

1. npm link in the root directory of your forked repo to link it globally
2. npm link material-ui in any project you want to use with your local fork.

[alitaheri]

@ffxsam Sorry for the late response. I was really busy yesterday. If you want the latest updates that are on the master branch the best way to do it is this:

1. Add "material-ui": "callemall/material-ui" as dependency instead of version. it will install from the github repository (master branch).
2. go inside the node_modules/material-ui/ folder and run npm install (if it fails to build run npm run build too)
3. go to node_modules/material-ui/node_modules folder and delete react from there. (as to prevent multiple reacts from being loaded in your application)

You now have the latest version.

In case you want to update your clone. don't use npm, use git, it will be easier. Just remember! after each update you will have to run npm run build inside your clone to update the lib folder.

[ffxsam]

Thanks @alitaheri! Though what I wanted to do was to use my own fork in my projects, that way as I fix things as I'm working, I can do PRs. So I assume I'd change step 1 above to:

1. Add "material-ui": "ffxsam/material-ui" as dependency instead of version.

[alitaheri]

Or...

1. cd node_modules/material-ui/
2. git remote add ffxsam https://github.com/ffxsam/material-ui.git

You can just modify what ever you want in that folder. it will be like your working directory inside the modules folder. you can code, build and see things change. without having to checkout from the server.

[nathanmarks]

Refer to #3614 for discussion on better responsive component support.