Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Typo in CSS Media Query demo of Breakpoints #30215

Closed
2 tasks done
HelpMe-Pls opened this issue Dec 15, 2021 · 3 comments · Fixed by #30219
Closed
2 tasks done

[docs] Typo in CSS Media Query demo of Breakpoints #30215

HelpMe-Pls opened this issue Dec 15, 2021 · 3 comments · Fixed by #30219
Labels
docs Improvements or additions to the documentation

Comments

@HelpMe-Pls
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

In the CSS Media Query (https://mui.com/customization/breakpoints/#css-media-queries) demo's source code , you defined:
image

And the output renders it as down(sm): red, which was supposed to be down('md'): purple ?
image

I know that it seems trivial for a typo but on my first approach to MUI's breakpoints, it looks confusing.

Expected behavior 🤔

To have the demo's output reflecting what it is intended to.

Steps to reproduce 🕹

Visit https://mui.com/customization/breakpoints/#css-media-queries and try it out

Context 🔦

I'm trying to learn about MUI's breakpoints.

Your environment 🌎

I tried it out on the section's attached sandbox (https://codesandbox.io/s/i96ii?file=/demo.tsx)
My browser: Microsoft Edge
Version 96.0.1054.53 (Official build) (64-bit)

@HelpMe-Pls HelpMe-Pls added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 15, 2021
@michaldudak
Copy link
Member

Good catch! We shouldn't have used colors from the theme here.

@michaldudak michaldudak added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 15, 2021
@HelpMe-Pls
Copy link
Contributor Author

@michaldudak Thanks for your response. My initial question was the breakpoints.down('md') which was rendered as down('sm'). Very much appreciate your fix on the color, but the main point of my issue seems to be overlooked in your PR:

theme.breakpoints.down('md'):
image

Should be rendered as down(md): red instead of down(sm): red
image

@michaldudak
Copy link
Member

Ahh, right, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants