Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Can't read Docs in English from a different country #30772

Closed
mickaelxd opened this issue Jan 25, 2022 · 2 comments
Closed

[docs] Can't read Docs in English from a different country #30772

mickaelxd opened this issue Jan 25, 2022 · 2 comments
Assignees
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation i18n internationalization

Comments

@mickaelxd
Copy link

mickaelxd commented Jan 25, 2022

Current behavior 😯

I'm trying to read the docs https://mui.com/
but i'm in Brazil, and when I enter the website, it redirects me to https://mui.com/pt/
And on the right drawer I can't change to English, because redirects me again.

Expected behavior 🤔

It should be able to switch between languages without the redirect.

Steps to reproduce 🕹

Steps:

@mickaelxd mickaelxd added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 25, 2022
@mickaelxd mickaelxd changed the title Can't read Docs in English from a different country. -- Jan 25, 2022
@mbrookes mbrookes added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 23, 2022
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label May 23, 2022
@oliviertassinari oliviertassinari changed the title -- [docs] Can't read Docs in English from a different country May 23, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented May 23, 2022

The root problem might be that the language picker shouldn't be behind the settings button.

v4

Screenshot 2022-05-24 at 00 47 47

v5

Screenshot 2022-05-24 at 01 06 25

https://v5-0-6.mui.com/getting-started/usage/

HEAD

Screenshot 2022-05-24 at 00 47 30

All the most popular repositories (https://gitstar-ranking.com/repositories) show the language setting directly:

@siriwatknp Do you recall why we did this change in #30283? I don't see the direct connection. We might want to reopen this issue if we see more instances of this issue in the future.

@oliviertassinari oliviertassinari added l10n localization i18n internationalization and removed duplicate This issue or pull request already exists labels May 23, 2022
@oliviertassinari
Copy link
Member

We also had #30816 on a similar pain point.

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed l10n localization labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation i18n internationalization
Projects
None yet
Development

No branches or pull requests

4 participants