Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Menu unstyled page auto focus to useMenu and useMenuItem hooks demo #31981

Closed
2 tasks done
ivan-ngchakming opened this issue Mar 25, 2022 · 2 comments · Fixed by #34166
Closed
2 tasks done

[docs] Menu unstyled page auto focus to useMenu and useMenuItem hooks demo #31981

ivan-ngchakming opened this issue Mar 25, 2022 · 2 comments · Fixed by #34166
Assignees
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base

Comments

@ivan-ngchakming
Copy link
Contributor

ivan-ngchakming commented Mar 25, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Upon opening the Menu unstyled componet doc, the useMenu and useMenuItem hooks demo is set as the active element automatically, force scrolling down to this demo instead of the start of the page.

Expected behavior 🤔

Disable set focus to elements in this demo. So user can view this page from the top upon visiting the page.

Steps to reproduce 🕹

Steps:

  1. visit https://mui.com/base/react-menu/

Context 🔦

Encountered this while working on #31012, didn't realize there were two more demo above until fiddling around with the page for a while. Would love to work on a PR if needed.

Your environment 🌎

`npx @mui/envinfo`
  I am using Firefox and Chrome btw.
@ivan-ngchakming ivan-ngchakming added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 25, 2022
@adhyayaThakur
Copy link

Hello, may I take this issue.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Mar 26, 2022
@michaldudak
Copy link
Member

@adhyayaThakur sure, go ahead. Let's modify the demo to not display the menu immediately, but after clicking on a button (similar to other demos).

@michaldudak michaldudak added component: menu This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 29, 2022
@ZeeshanTamboli ZeeshanTamboli self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
5 participants