Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dialog created without Modal #32834

Open
2 tasks done
darkgrayknight opened this issue May 19, 2022 · 3 comments
Open
2 tasks done

Add a Dialog created without Modal #32834

darkgrayknight opened this issue May 19, 2022 · 3 comments
Assignees
Labels
component: dialog This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@darkgrayknight
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Dialogs are both modal and non-modal, as noted in mdn web docs and w3c aria.

I am currently building some tool windows and toolboxes that would be great as floating, draggable dialogs that allow interaction on the page below as well as in the dialog. However, the current Dialog is build on top of Modal, and that creates issues with accessibility for accessing controls on the page and in the dialog.

Can we add a property to Dialog (and possibly Drawer) for isModal={false}?

Examples 🌈

A decent example is Photopea. When you select Layer -> Layer Style -> Blending Options and you get a floating, draggable dialog with options inside the dialog, but also can still select other things at the same time.

Motivation 🔦

Really, the summary expresses it best. Dialogs can be modal or non-modal. Why is Material UI limited to only modal Dialogs? And why create more accessibility issues by limiting to modals? While there are ways to turn off aspects of the Modal component, it has several bugs that still create accessibility issues that have not yet been fixed.

@darkgrayknight darkgrayknight added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 19, 2022
@siriwatknp siriwatknp added new feature New feature or request component: dialog This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 25, 2022
@plgagnon2
Copy link

bumping this, really need a non modal Dialog

@siriwatknp
Copy link
Member

siriwatknp commented Feb 2, 2023

I checked the specs of both MD2 and MD3, they are all modal.

I think we need another component for the non-modal dialog. This request is similar to Select component for not being a modal.

@plgagnon2
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants