Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleButton] variant prop is missing #34238

Closed
2 tasks done
burzaszsolt opened this issue Sep 9, 2022 · 5 comments
Closed
2 tasks done

[ToggleButton] variant prop is missing #34238

burzaszsolt opened this issue Sep 9, 2022 · 5 comments
Labels
component: toggle button This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists new feature New feature or request

Comments

@burzaszsolt
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

I'm trying to add a variant to the ToggleButton component on theme level and there is no such interface that I could override with module augmentation.

Expected behavior 🤔

I would expect to have a variant prop available with an extendable interface as described in the docs.

Steps to reproduce 🕹

Please check this sandbox.

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@burzaszsolt burzaszsolt added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 9, 2022
@burzaszsolt burzaszsolt mentioned this issue Sep 9, 2022
Closed
1 task
@burzaszsolt
Copy link
Author

I created a PR trying to fix the issue.

@hbjORbj hbjORbj added the component: toggle button This is the name of the generic UI component, not the React module! label Sep 9, 2022
@hbjORbj hbjORbj changed the title [ToggleButton] Variant prop is missing from type definition [ToggleButton] variant prop is missing from type definition Sep 9, 2022
@hbjORbj hbjORbj changed the title [ToggleButton] variant prop is missing from type definition [ToggleButton] variant prop is missing Sep 9, 2022
@siriwatknp
Copy link
Member

Similar to #33510

@burzaszsolt
Copy link
Author

@siriwatknp Similar indeed! I see in this PR that you approached it a bit different than I did in my PR. Should I also remove the "standard" variant from the type definition and the prop types?

@burzaszsolt
Copy link
Author

@michaldudak Could you check please? ☝️ I can make those changes on my PR if needed.

@siriwatknp siriwatknp mentioned this issue Sep 28, 2022
Closed
1 task
@mnajdova mnajdova added new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 28, 2022
@mnajdova mnajdova mentioned this issue Sep 30, 2022
Closed
2 tasks
@mnajdova
Copy link
Member

Duplicate of #33510, I've make the previous issue more general

@mnajdova mnajdova added the duplicate This issue or pull request already exists label Sep 30, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ToggleButton] Add optional variant prop burzaszsolt/material-ui
5 participants
@mnajdova @michaldudak @siriwatknp @hbjORbj @burzaszsolt