Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewCompact and ViewComfy are replacing each other. #34818

Closed
2 tasks done
alfe opened this issue Oct 19, 2022 · 3 comments
Closed
2 tasks done

ViewCompact and ViewComfy are replacing each other. #34818

alfe opened this issue Oct 19, 2022 · 3 comments
Labels
package: icons Specific to @mui/icons status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it

Comments

@alfe
Copy link

alfe commented Oct 19, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Steps:

  1. https://codesandbox.io/s/vigilant-kare-rq0qmy?file=/src/App.js

Current behavior 😯

It looks like ViewCompact and ViewComfy have been replaced.
icon-compare

Expected behavior 🤔

ViewComfy should be a collection of 12 points.

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
 System:
    OS: Windows 10 10.0.19044
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700
    Memory: 45.76 GB / 63.79 GB
  Binaries:
    Node: 16.14.0 - C:\Program Files\nodejs\node.EXE 
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD   
    npm: 8.3.1 - C:\Program Files\nodejs\npm.CMD     
  Utilities:
    Git: 2.37.3. - C:\Program Files\Git\mingw64\bin\git.EXE
  SDKs:
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
  IDEs:
    VSCode: 1.72.1 - C:\Program Files\Microsoft VS Code\bin\code.CMD
  Languages:
    Bash: 5.1.16 - C:\Program Files\Git\usr\bin\bash.EXE
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (106.0.1370.47)
    Internet Explorer: 11.0.19041.1566
@alfe alfe added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 19, 2022
@zannager zannager added the package: icons Specific to @mui/icons label Oct 19, 2022
@michaldudak
Copy link
Member

Where does this reference come from? It seems we've got it correct - "comfy" means larger panels, whereas "compact" is being able to fit more items on the screen.

This matches https://fonts.google.com/icons?icon.query=view+comfy&icon.style=Outlined and https://fonts.google.com/icons?icon.query=view+compact&icon.style=Outlined

@michaldudak michaldudak added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 19, 2022
@michaldudak michaldudak closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2022
@alfe
Copy link
Author

alfe commented Oct 19, 2022

The image is made from the screen shot of https://materialui.co/icon/view-comfy / https://materialui.co/icon/view-compact.
(I should have written it not only in the codesandbox but also in the description.)

Looking at GoogleFonts, there seems to be a current situation.

Using ViewComfy as an icon with a dividing line in the square, I was surprised that the icon changed by the update, so I created an issue.

If the current situation is as intended, there is no problem.
Sorry for confusing you.

@michaldudak
Copy link
Member

materialui.co is not the Google's official Material Design Icons site.
It would be the best to create a ticket in their bugtracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it
Projects
None yet
Development

No branches or pull requests

3 participants