Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FontIcon] as [Tab] icon not inheriting hoverColor or style #3577

Closed
TrySpace opened this issue Mar 3, 2016 · 2 comments
Closed

[FontIcon] as [Tab] icon not inheriting hoverColor or style #3577

TrySpace opened this issue Mar 3, 2016 · 2 comments
Labels
bug 🐛 Something doesn't work

Comments

@TrySpace
Copy link
Contributor

TrySpace commented Mar 3, 2016

When I use the FontIcon as a Tab icon:

 <Tab icon={<FontIcon hoverColor='pink' className="material-icons">home</FontIcon>} />         

It won't inherit the props for it.

When I give it style: { color: 'pink'} it also has no effect. (Although this should probably be done by using the ThemeManager, but I find the docs on that not really clear, should I use something like: palette: { iconColor: 'pink' }? Should I then wrap MuiThemeProvider around the Tabs component?)

  • Material-UI: 0.15.0-alpha.1
  • React: 14.3
  • Browser: Chrome
@asidiali
Copy link

Experiencing the same issue w/ material-ui@^0.15.0-beta.2, FontIcon within icon prop isn't inheriting color prop or style.

@oliviertassinari
Copy link
Member

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

4 participants