Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isDeviceSize(Sizes.SMALL) will always return true in style-resizable.js #3660

Closed
halayli opened this issue Mar 10, 2016 · 2 comments
Closed

isDeviceSize(Sizes.SMALL) will always return true in style-resizable.js #3660

halayli opened this issue Mar 10, 2016 · 2 comments
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@halayli
Copy link

halayli commented Mar 10, 2016

I am not sure if this is intended but isDeviceSize(Sizes.SMALL) will always be true regardless of the screen size since {3,2,1} >= 1.
@alitaheri
Copy link
Member

We intend to remove that mixin. It's proven a bit hard to do it, but we'll get there. So I think we shouldn't fix the mixin, just kill it 😮 🔫

@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Mar 12, 2016
@tintin1343
Copy link
Contributor

Closing this.

This was referenced Aug 19, 2021
Open
Open
Open
Open
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 24, 2021
Open
@maniator maniator mentioned this issue May 13, 2022
Open
@akashmitra akashmitra mentioned this issue May 13, 2022
Open
@hzhz hzhz mentioned this issue May 14, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this issue May 14, 2022
Open
@akashmitra akashmitra mentioned this issue Jun 20, 2023
Open
@zhaleTaheri zhaleTaheri mentioned this issue Nov 25, 2023
Open
@akashmitra akashmitra mentioned this issue Mar 22, 2024
Open
@hzhz hzhz mentioned this issue Mar 22, 2024
Open
@maniator maniator mentioned this issue Mar 22, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this issue Mar 22, 2024
Open
@maniator maniator mentioned this issue May 13, 2024
Open
@hzhz hzhz mentioned this issue May 13, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this issue May 14, 2024
Open
@akashmitra akashmitra mentioned this issue May 15, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this issue May 22, 2024
Open
@maniator maniator mentioned this issue May 22, 2024
Open
@akashmitra akashmitra mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@halayli @oliviertassinari @alitaheri @tintin1343