Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-next] Support modal and non-modal option for components #38756

Open
2 tasks done
DiegoAndai opened this issue Sep 1, 2023 · 2 comments
Open
2 tasks done

[material-next] Support modal and non-modal option for components #38756

DiegoAndai opened this issue Sep 1, 2023 · 2 comments
Assignees
Labels
component: autocomplete This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! component: drawer This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! component: snackbar This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component. on hold There is a blocker, we need to wait

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Sep 1, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

This is part of the #38630 effort.

All components that involve a floating element should provide a prop to control whether that element should behave like a modal or not:

  • Autocomplete
  • Dialog
  • Drawer
  • Menu
  • Select
  • Snackbar
  • Swipeable Drawer

Motivation 🔦

The usage of modal or non-modal floating elements should be made in userland, as it varies from use case to use case.

This same issue was raised in #17353 (comment).

@DiegoAndai DiegoAndai added component: dialog This is the name of the generic UI component, not the React module! component: drawer This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! component: snackbar This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component. component: autocomplete This is the name of the generic UI component, not the React module! v6.x labels Sep 1, 2023
@DiegoAndai DiegoAndai added this to the v6 milestone Sep 1, 2023
@DiegoAndai DiegoAndai self-assigned this Sep 1, 2023
@imevanc
Copy link
Contributor

imevanc commented Sep 1, 2023

@DiegoAndai - Have you started working on any of them or can you assign this issue to me?

@DiegoAndai
Copy link
Member Author

Hey @imevanc, thanks for the interest 😊

This work is planned for v6, not for v5. We still haven't started the work on these components for v6 so I'll mark this as "on hold". Before diving into this issue, We must migrate them to use Base UI hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! component: drawer This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! component: snackbar This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component. on hold There is a blocker, we need to wait
Projects
Status: Backlog
Development

No branches or pull requests

4 participants