Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputAdornment][material-next] Add InputAdornment component #39628

Open
1 of 8 tasks
mj12albert opened this issue Oct 27, 2023 · 1 comment
Open
1 of 8 tasks

[InputAdornment][material-next] Add InputAdornment component #39628

mj12albert opened this issue Oct 27, 2023 · 1 comment
Assignees
@mj12albert
Labels
component: text field This is the name of the generic UI component, not the React module! design: material you

Comments

@mj12albert
Copy link
Member

mj12albert commented Oct 27, 2023 •
edited
Loading

Part of #38374

Migration Steps

  • Copy component files from material (v5) to material-next (PR)
  • Remove deprecated components and componentsProps props
  • Drop support for ThemeProvider in favor of CssVarsProvider
  • Migrate component to Typescript
  • Refactor component to use Base UI’s hook if it exists
  • Implement Material You design specs
  • Add component playground to v5 docs will be part of the TextField playground
  • Refactor styles to use component CSS Variables
@mj12albert mj12albert self-assigned this Oct 27, 2023
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 27, 2023
@mj12albert mj12albert added component: text field This is the name of the generic UI component, not the React module! design: material you and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 27, 2023
@mj12albert
Copy link
Member Author

mj12albert commented Oct 31, 2023 •
edited
Loading

There are some very noticeable differences in Material You in the placement of startAdornment in relation to the label

In MD2, the examples only show using the start adornment as "prefix text":

In Material You, icon adornments are more prominent but more importantly, the label (in every state) never crosses into the (start) adornment's position in the layout

Filled text field specs
image

Filled text field configurations
unnamed

This was referenced Oct 31, 2023
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj12albert mj12albert

Labels
component: text field This is the name of the generic UI component, not the React module! design: material you
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[InputAdornment][material-next] Add InputAdornment component mj12albert/material-ui
1 participant
@mj12albert