Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Showing/Hiding Menu When Not Nested #404

Closed
omerts opened this issue Mar 8, 2015 · 2 comments
Closed

[Menu] Showing/Hiding Menu When Not Nested #404

omerts opened this issue Mar 8, 2015 · 2 comments
Labels
component: menu This is the name of the generic UI component, not the React module!

Comments

@omerts
Copy link
Contributor

omerts commented Mar 8, 2015

Hello,

I am trying to manually control the visibility of a Menu element, so I set hideable to be true, and visible is binded to a changing state (just like in the NestedMenu you created). The problem is that the CSS that sets the element's opacity, has a selector which is specific to a nested menu only.
Instead, you should set the opacity to 1 using the "mui-visible" selector.

Omer

@jkruder
Copy link
Contributor

jkruder commented Mar 9, 2015

Looks like setting the following in menu.less fixes the issue.

&.mui-visible {
      opacity: 1;
      position: static;
      ...
}

@hai-cea, do you want me to submit a PR?

@hai-cea hai-cea changed the title Showing/Hiding Menu When Not Nested [Menu] Showing/Hiding Menu When Not Nested Jun 18, 2015
@shaurya947
Copy link
Contributor

@omerts do you still experience this issue with the new MenuItem component? Maybe try overriding the inline style prop to decide whether or not you want to show the item?

(closing for now, feel free to comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants