Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system][zero] Consolidate the arguments in the variant's props callback #41220

Closed
mnajdova opened this issue Feb 21, 2024 · 0 comments · Fixed by #41219
Closed

[system][zero] Consolidate the arguments in the variant's props callback #41220

mnajdova opened this issue Feb 21, 2024 · 0 comments · Fixed by #41219
Labels
package: pigment-css Specific to @pigment-css/* package: system Specific to @mui/system

Comments

@mnajdova
Copy link
Member

mnajdova commented Feb 21, 2024

Steps to reproduce

The zero-runtime and the styled have different arguments in the variant's callback, when it comes to internal state of the components. For example:

MUI System:

variants: [{
  props: props => props.ownerState.checked === true
}]

Zero runtime:

variants: [{
  props: props => props.checked === true
}]

Current behavior

No response

Expected behavior

The argument should be identical as the styling solution can be interchangeable

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: variants, props callback

@mnajdova mnajdova added status: waiting for maintainer These issues haven't been looked at yet by a maintainer package: system Specific to @mui/system package: pigment-css Specific to @pigment-css/* and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 21, 2024
@mnajdova mnajdova moved this to In progress in Pigment CSS Feb 21, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Pigment CSS Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: pigment-css Specific to @pigment-css/* package: system Specific to @mui/system
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant