-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Add capacity to filter the search scope #41541
Comments
Hey @oliviernt, thanks for opening the issue! I'm not immediately opposed to your suggestion, but I think there's some bug with the Algolia search ranking that's not suggesting the most relevant page, which, in this case, should be the Date Picker component docs from MUI X instead of Toolpad. @mui/docs-infra, any ideas here? |
For some pages, there are filters. For example searchin when you are in a picker docs pages, search query will get the attribute Some url such as But we could look for lowering the importances of toopads API pages, because if they put one page per components, they will always appear first |
Hey @alexfauquette @danilo-leal, thank you both for your fast response time. Lowering the importance of toolpad would indeed, solve my current issue but it could possibly deteriorate the experience for other users. My idea was that selecting which products I'm interested in would make a nice feature in itself. It would reduce the search scope, allow for people intereseted in toolpad (or any other product) to select that and make it flexible in the long run as you guys are providing more and more products... |
Yeah, I agree that having the option to tailor the search results ranking to your preference would be great! We'd still need a ranking from our side, though, because if you're a new visitor accessing the website for the first time, you wouldn't have a preference just yet. So, considering this specific example, Toolpad's Date Picker docs page shouldn't be the first resource that pops up if you're looking for that. |
Regression fixed, https://mui.com/ is back to the baseline: Details. When I do the search of @oliviernt's query "date picker" in the Agolia's UI, it tells me that Which doesn't make sense to me. Turns out, it's a regression I introduced on a bug I fixed. This change solved the problem: // % from https://docs.google.com/spreadsheets/d/1x9uTSMlu4xug2SfHrvr5amZ2HokYBoQaSozHmRRdVqw/edit#gid=907743010
const baselinePopulartyProductId = {
material-ui: 83,
- "mui-x": 12,
+ x: 12,
system: 4,
"base-ui": 2,
"joy-ui": 2,
toolpad: 1,
}; It needed to match with: material-ui/docs/src/modules/utils/getProductInfoFromUrl.ts Lines 3 to 15 in 6da671c
Now, I don't think we should close this issue until the larger discussion goes to completion. It's point 3. of #16502. What we could explore:
AWS MUX https://docs.mux.com/?q=al
It feels like it only makes sense for when you are on https://mui.com/, but anytime you go to a product, it should only show that product results. We could make this change: customRanking: [
"desc(weight.pageRank)",
"desc(weight.level)",
"asc(weight.position)",
"desc(weight.popularity)",
],
ranking: [
+ "filters",
"words",
- "filters",
"typo",
"attribute",
"proximity",
"exact",
"custom",
], but it's kind of strange. Or, we could also make two different searches one with the filter set, and one without, so we would only show one type of results at the time. Or we could just hide all non-product related results, forcing developers to go to each doc. This might be best. |
Thank you for the fix! 🚀 My personal 2 cents on both points:
|
Looks like we are missing |
Given there was a quick fix for the original/more immediate problem, I went ahead and rephrased the issue's title so it reflects the "filter the search scope" feature mentioned above that we'll want to explore at some point to potentially solve the issue more holistically! |
@flaviendelangle On view-source:https://next.mui.com/x/react-tree-view/ I see: <meta name="mui:productId" content="x-tree-view"/><meta name="mui:productCategoryId" content="x"/> We are good. |
But shouldn't we have |
Summary
Often when I search for something on the MUI docs through the Algolia search (Strg + K), I'm presented irrelevant search results for the Toolpad components first.
It'd be great to have the ability to exclude products from search.
Examples
Example of the results when searching for "DatePicker"
Motivation
No response
Search keywords: search toolpad
The text was updated successfully, but these errors were encountered: