Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mui-material][mui-system] Drop support for Safari < 14 #42459

Closed
LukasTy opened this issue May 31, 2024 · 3 comments
Closed

[mui-material][mui-system] Drop support for Safari < 14 #42459

LukasTy opened this issue May 31, 2024 · 3 comments
Assignees
Labels
breaking change package: material-ui Specific to @mui/material package: system Specific to @mui/system v6.x

Comments

@LukasTy
Copy link
Member

LukasTy commented May 31, 2024

The minimal supported Safari version is 15.4, which means that deprecated solutions catering for older browsers can be dropped.

One such instance is the useMediaQuery hook, using addListener and removeListener:

// TODO: Use `addEventListener` once support for Safari < 14 is dropped
queryList.addListener(updateMatch);
return () => {
active = false;
queryList.removeListener(updateMatch);
};

https://developer.mozilla.org/en-US/docs/Web/API/MediaQueryList/addListener

Link to Slack message: https://mui-org.slack.com/archives/C0170JAM7ML/p1716988696389809

At the same time, it would be great to search for other solutions that might no longer be necessary:

Search keywords:

@aarongarciah
Copy link
Member

@DiegoAndai I haven't found anything worth deleting regarding Safari < 14 support. I'm marking this as closed unless you tell me otherwise.

@DiegoAndai
Copy link
Member

DiegoAndai commented Jul 1, 2024

Thanks @aarongarciah, I don't find anything either 🙌🏼.

For the record, there are some instances in which we call out for Safari updates, for example:

But all of them are on the mui-base package, which is the stale one we're not updating.

@LukasTy
Copy link
Member Author

LukasTy commented Jul 1, 2024

Thanks to both of you for the detailed replies and confirmation regarding the mui-base cases. 😉 🙏 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change package: material-ui Specific to @mui/material package: system Specific to @mui/system v6.x
Projects
None yet
Development

No branches or pull requests

3 participants