Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Clean up bundle size names #43441

Open
Janpot opened this issue Aug 26, 2024 · 0 comments
Open

[code-infra] Clean up bundle size names #43441

Janpot opened this issue Aug 26, 2024 · 0 comments
Assignees
Labels
scope: code-infra Specific to the core-infra product

Comments

@Janpot
Copy link
Member

Janpot commented Aug 26, 2024

From https://www.notion.so/mui-org/code-infra-Cleanup-bundle-size-tracker-names-af489e26331c4faa9e44a81ee4e1f06f

Assuming

// WARNING: Changing the name will break tracking of bundle size over time
// If the name of the package changes, rename its display name in https://github.com/eps1lon/mui-contributor-dashboard/blob/main/src/pages/SizeComparison.tsx
is not useful for us anymore.

  • Rename the bundle ids:

    • @material-ui/core => @mui/material
    • etc...
  • Remove

    const componentName = path.basename(path.dirname(componentPath));
    let entryName = componentName;
    // adjust for legacy names
    if (componentName === 'Paper') {
    entryName = '@material-ui/core/Paper.esm';
    } else if (componentName === 'TextareaAutosize') {
    entryName = '@material-ui/core/Textarea';
    }

Search keywords:

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Aug 26, 2024
@Janpot Janpot self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

No branches or pull requests

2 participants
@Janpot and others