Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Password eye icon disappears in Edge #44756

Closed
loronange opened this issue Dec 13, 2024 · 4 comments
Closed

[TextField] Password eye icon disappears in Edge #44756

loronange opened this issue Dec 13, 2024 · 4 comments
Assignees
Labels
browser: Edge component: text field This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it

Comments

@loronange
Copy link

loronange commented Dec 13, 2024

Steps to reproduce

Steps:

  1. Open this link to live example: here
  2. Start typing text in the TextField of type password
  3. Eye icon will appear
  4. Click outside the TextField
  5. Go back into the TextField
  6. Start entering text
  7. The eye icon does not appear again

If you add an adornment then you get two eye icons when entering text as seen in the documentation here

Current behavior

The eye icon disappear from TextField of type password after refocus

Expected behavior

The eye icon should either always be there or not be there at all when the user types the password

Context

I want the user to have the option to view the password in plain text by clicking the eye icon

Your environment

import TextField from '@mui/material/TextField';
<TextField type="password" />

Search keywords: TextField password type icon

@loronange loronange added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 13, 2024
@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label Dec 13, 2024
@mj12albert
Copy link
Member

@loronange I can't reproduce in both demos you linked – this and this – in particular the ones under "Form props" do not have any adornments

Could you share a sandbox or a recording?

@mj12albert mj12albert added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 14, 2024
@loronange
Copy link
Author

Here is a video recording. I did that test on Edge:
https://github.com/user-attachments/assets/873728d1-8915-4e27-8bba-c95fb628293b

I noticed that on Chrome, the eye icon does not show at all.

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Dec 14, 2024
@mj12albert mj12albert assigned mj12albert and unassigned siriwatknp Dec 15, 2024
@mj12albert
Copy link
Member

mj12albert commented Dec 15, 2024

@loronange This is the "password reveal button" from Edge: https://learn.microsoft.com/en-us/microsoft-edge/web-platform/password-reveal

You can suppress it with CSS:

::-ms-reveal {
  display: none;
}

@mj12albert mj12albert added external dependency Blocked by external dependency, we can’t do anything about it and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 15, 2024
@mj12albert mj12albert changed the title TextField password eye icon disappear [TextField] Password eye icon disappears in Edge Dec 15, 2024
@DiegoAndai DiegoAndai added the status: waiting for author Issue with insufficient information label Dec 19, 2024
@aarongarciah aarongarciah added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it and removed status: waiting for author Issue with insufficient information labels Dec 19, 2024
@aarongarciah
Copy link
Member

Hi @loronange! The behavior you're experiencing in Edge is not related to the TextField component from Material UI. As you can see in the screen recording below, Edge has this behavior in native <input type="password">: Edge shows the reveal password button only when you fill the input. Once the input is filled, the reveal button is not shown again until you empty the input.

Kapture.2024-12-19.at.15.42.12.mp4

The demo is from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/password

Closing this since is the expected behavior.

@aarongarciah aarongarciah closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: Edge component: text field This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it
Projects
None yet
Development

No branches or pull requests

6 participants