Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Start a small collaboration with RJSF to enhance the Material UI theme they have created? #45011

Open
TheOneTheOnlyJJ opened this issue Jan 12, 2025 · 2 comments
Assignees
Labels
ready to take Help wanted. Guidance available. There is a high chance the change will be accepted RFC Request For Comments waiting for 👍 Waiting for upvotes

Comments

@TheOneTheOnlyJJ
Copy link

TheOneTheOnlyJJ commented Jan 12, 2025

What's the problem?

The RJSF library has a community-maintained Material UI theme. The library is actively maintained and used in many projects.

However, some widgets do not properly use Material UI theming. There is the data-url widget and the date & time ones: date, date-time, and time. Documentation here.

I'm sure there are developers here who had to build their custom widgets for the RJSF Material UI theme to conform to Material Design properly. Even sharing these examples would be helpful for those who don't yet have their solutions.

I decided to start this RFC after noticing that besides the date & time widgets missing, the data-url (file) widget is also missing proper Material UI integration. Creating this widget does not seem like a huge endeavor.

@oliviertassinari What do you think? Could the Material UI team consider contributing to the RJSF Material UI theme at some point?
Even just documentation examples (either on our side or theirs) would greatly help. I opened an issue regarding this over at rjsf-team/react-jsonschema-form#4447.
The Material UI theme for RJSF was, at least for me, a deciding factor in adopting Material UI overall in my project.
As a taste of what this would take, here's an issue I opened where I made a custom Material UI password widget for RJSF, with an eye icon to show/hide the input: rjsf-team/react-jsonschema-form#4274

What are the requirements?

No response

What are our options?

No response

Proposed solution

No response

Resources and benchmarks

No response

Search keywords:

@TheOneTheOnlyJJ TheOneTheOnlyJJ added RFC Request For Comments status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2025
@mnajdova mnajdova assigned DiegoAndai and unassigned siriwatknp Jan 14, 2025
@DiegoAndai DiegoAndai added waiting for 👍 Waiting for upvotes ready to take Help wanted. Guidance available. There is a high chance the change will be accepted and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 15, 2025
@DiegoAndai
Copy link
Member

Hey @TheOneTheOnlyJJ, thanks for reaching out.

I added the waiting for 👍🏼 label so the community can vote for this initiative. If you want to see this implemented, please add a 👍🏼 reaction to the issue's description. I also added the ready to take label if anyone wants to work on this.

Finally, tagging @LukasTy and @joserodolfofreitas as the Date Picker seems to be one of the main reasons for this post.

If anyone start working on this, please let us know 😊

@TheOneTheOnlyJJ
Copy link
Author

@nickgros has shared one of his examples for a potential DateTimePicker widget here. It can serve as a reference point for implementations for the TimeWidget and DateWidget. Having reference code like this is surely a good first step toward better, more customizable implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to take Help wanted. Guidance available. There is a high chance the change will be accepted RFC Request For Comments waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

3 participants