-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundle jsx and react-tools as dev-dependencies #616
Labels
docs
Improvements or additions to the documentation
Comments
@mderazon I show react-tools is a dev-dependency in the package.json? https://github.com/callemall/material-ui/blob/master/package.json#L40 |
My bad, you're right. For some reason, it didn't build when I tried it. Tried it again and it seems fime |
This was referenced Nov 29, 2021
oliviertassinari
added
the
status: waiting for maintainer
These issues haven't been looked at yet by a maintainer
label
Dec 25, 2022
zannager
added
docs
Improvements or additions to the documentation
and removed
status: waiting for maintainer
These issues haven't been looked at yet by a maintainer
labels
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
running
relies on the user to have
jsx
andreact-tools
installed globally.IMO it's much better to bundle them locally in
package.json
.This way the command will run without any external dependencies.
The text was updated successfully, but these errors were encountered: