Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] Does not propagate transitionDuration prop to [Grow] #8034

Closed
novembrea opened this issue Sep 4, 2017 · 3 comments
Closed

[Popover] Does not propagate transitionDuration prop to [Grow] #8034

novembrea opened this issue Sep 4, 2017 · 3 comments
Labels
bug 🐛 Something doesn't work component: Popover The React component. good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@novembrea
Copy link
Contributor

novembrea commented Sep 4, 2017 •
edited
Loading

Hey guys, the line in question:
https://github.com/callemall/material-ui/blob/v1-beta/src/Popover/Popover.js#L364
On the lower end mobile devices Grow transition doesn't work smooth enough so I tend to dynamically disable transitions on all mobile devices but it no longer works since the last couple of version I think. I'm not sure whether it is intentionally. Please advise.
@novembrea novembrea changed the title [Menu] Does not propagate transitionDuration prop to [Grow] [Popover] Does not propagate transitionDuration prop to [Grow] Sep 4, 2017
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: Popover The React component. v1 labels Sep 4, 2017
@oliviertassinari
Copy link
Member

This property was left behind by mistake. You are right, we should provide it to the Grow component.

@novembrea
Copy link
Contributor Author

Do you want a PR?

@oliviertassinari
Copy link
Member

@nvma This would be great 👍 .

@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Sep 4, 2017
@novembrea novembrea mentioned this issue Sep 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Popover The React component. good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@novembrea @oliviertassinari