[Typescript] Questions on the styling types

[wcandillon]

I have a question regarding the StyledComponentProps interface. classes is marked as optional even though it shouldn't be if the component is styled using withStyle?

I had a similar typedefinition in my project:

export interface StylingProps<T extends string> {
    classes: { [key in T]: string };
    style?: Partial<CSSProperties>;
    className?: string;
}

Here classes is marked as mandatory as well as it's class names. I was hoping to replace this type with StyledComponentProps but it doesn't seem to be exactly the same. am I missing something?

[wcandillon]

I have a similar question with the type of the classes property within StyledComponentProps. Why is it using Partial<>? Should the developer be obligated to provide all the classe definitions?

[wcandillon]

Everywhere I have to update my code from:

        const {classes, anotherProp} = this.props;

to

        const {anotherProp} = this.props;
        const classes = this.props.classes as ClassNameMap<Classes>;

What is the best practice?

[pelotom]

@wcandillon see the discussion on #8447.

[wcandillon]

Thanks a lot I was able to solve my issues.