Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: ability to set em sizes on <CircularProgress> #9699

Closed
1 task done
jedwards1211 opened this issue Jan 2, 2018 · 0 comments
Closed
1 task done

Feature request: ability to set em sizes on <CircularProgress> #9699

jedwards1211 opened this issue Jan 2, 2018 · 0 comments
Labels
component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module!

Comments

@jedwards1211
Copy link
Contributor

jedwards1211 commented Jan 2, 2018 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

<CircularProgress> is most often used as a loading spinner. I usually find it most convenient to style my loading spinners to be sized relative to the text, for example 1.2em diameter, so that I don't have to waste time styling each particular usage. But currently <CircularProgress> only supports a fixed pixel size.

So would you be willing to make the API (or accept a PR to) support any valid CSS length value (as a string)?
@jedwards1211 jedwards1211 mentioned this issue Jan 2, 2018
Merged
@oliviertassinari oliviertassinari added the component: CircularProgress The React component label Jan 2, 2018
@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jedwards1211 @oliviertassinari