Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Missing eslint import/no-cycle in MUI X / flatten grid folder #10114

Closed
oliviertassinari opened this issue Aug 22, 2023 · 2 comments · Fixed by #11946
Closed

[DataGrid] Missing eslint import/no-cycle in MUI X / flatten grid folder #10114

oliviertassinari opened this issue Aug 22, 2023 · 2 comments · Fixed by #11946
Assignees
@cherniavskii
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes test

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 22, 2023 •
edited
Loading

See #10062 as proof import/no-cycle no longer covers the source of the data grid.

For the solution, the best one seems to remove this strange grid folder https://github.com/mui/mui-x/tree/master/packages/grid. Why is it not flat in the first place?

Initially open as a Notion Task
@oliviertassinari oliviertassinari added test core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels Aug 22, 2023
@oliviertassinari oliviertassinari mentioned this issue Aug 22, 2023
Merged
@flaviendelangle
Copy link
Member

Why is it not flat in the first place?

I think it goes back all the way to Damien
But I'm 100% in favor of flattening, it would simplify the bundling process as well

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 22, 2023 •
edited
Loading

Why is it not flat in the first place?

I recall it was because our package names had no prefixes, so they wouldn't sort well alphabetically.
Now that we use x-component-name as a prefix, the initial problem is gone :).

@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Aug 28, 2023
@cherniavskii cherniavskii self-assigned this Sep 14, 2023
@cherniavskii cherniavskii moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Sep 15, 2023
@cherniavskii cherniavskii moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Feb 5, 2024
@cherniavskii cherniavskii mentioned this issue Feb 5, 2024
Merged
@DanailH DanailH moved this from 🏗 In progress to ✅ Done in MUI X Data Grid Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherniavskii cherniavskii

Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes test
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Flatten grid packages folder cherniavskii/mui-x
3 participants
@oliviertassinari @flaviendelangle @cherniavskii