Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XGrid] Server-side filtering and multi-column filtering don't work well together #1026

Closed
2 tasks done
jamintz opened this issue Feb 10, 2021 · 1 comment · Fixed by #1029
Closed
2 tasks done

[XGrid] Server-side filtering and multi-column filtering don't work well together #1026

jamintz opened this issue Feb 10, 2021 · 1 comment · Fixed by #1029
Assignees
Labels
bug 🐛 Something doesn't work

Comments

@jamintz
Copy link

jamintz commented Feb 10, 2021

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When running server-side filtering (eg the example given here) but changed to XGrid), if you press the "add filter" button in the panel it seems like nothing happens. No additional filter row is added as expected (and how it works in XGrid without server-side filtering).
Screen Shot 2021-02-10 at 12 38 15 PM

Clicking elsewhere and then back to filter loads the filter panel again, it will now have N rows for every time you clicked "add filter" before
Screen Shot 2021-02-10 at 12 38 23 PM

Expected Behavior 🤔

When pressing "add filter" while running server-side filtering in XGrid, an additional row should appear in the filter panel

Steps to Reproduce 🕹

Steps:

  1. Load https://material-ui.com/components/data-grid/filtering/#server-side-filter locally or in codesandbox, using XGrid instead of DataGrid – example here: https://codesandbox.io/s/material-demo-forked-mv2xz?file=/demo.js
  2. Filter the column
  3. Press the "add filter" button
  4. Observe no change to filter panel until you click elsewhere then back on filters

Context 🔦

A user should be able to both use server-side filtering and multi-column filtering nicely together

Your Environment 🌎

Observed using Chrome 88

 System:
    OS: macOS 11.1
  Binaries:
    Node: 15.8.0 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.5.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 88.0.4324.150
    Edge: Not Found
    Firefox: 84.0.1
    Safari: 14.0.2
  npmPackages:
    @material-ui/core: ^4.11.3 => 4.11.3 
    @material-ui/icons: ^4.11.2 => 4.11.2 
    @material-ui/lab: ^4.0.0-alpha.57 => 4.0.0-alpha.57 
    @material-ui/styles:  4.11.3 
    @material-ui/system:  4.11.3 
    @material-ui/types:  5.1.0 
    @material-ui/utils:  4.11.2 
    @material-ui/x-grid: ^4.0.0-alpha.19 => 4.0.0-alpha.19 
    @material-ui/x-grid-data-generator: ^4.0.0-alpha.19 => 4.0.0-alpha.19 
    @material-ui/x-license:  4.0.0-alpha.19 
    @types/react:  17.0.1 
    react: ^17.0.1 => 17.0.1 
    react-dom: ^17.0.1 => 17.0.1 

@jamintz
Copy link
Author

jamintz commented Feb 10, 2021

This is mostly resolved with a full implementation where it's actually updating on change, however it still may be useful to have a better / more complete example

@dtassone dtassone added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 11, 2021
@dtassone dtassone self-assigned this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants