Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Refactor event handling to avoid stopping propagation #10397

Closed
LukasTy opened this issue Sep 20, 2023 · 0 comments · Fixed by #11481
Closed

[TreeView] Refactor event handling to avoid stopping propagation #10397

LukasTy opened this issue Sep 20, 2023 · 0 comments · Fixed by #11481
Assignees
@flaviendelangle
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@LukasTy
Copy link
Member

LukasTy commented Sep 20, 2023

Created from #10123 (comment)

Investigate the possibility of not using event.stopPropagation, but relying on preventDefault and isDefaultPrevented or a similar mechanism to control the event flow.
@LukasTy LukasTy added enhancement This is not a bug, nor a new feature component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Sep 20, 2023
@LukasTy LukasTy mentioned this issue Sep 20, 2023
Merged
@LukasTy LukasTy mentioned this issue Oct 4, 2023
Closed
This was referenced Dec 21, 2023
Closed
Merged
@flaviendelangle flaviendelangle self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tree view] Cleanup onKeyDown handler flaviendelangle/mui-x
2 participants
@flaviendelangle @LukasTy