Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Data Grid - Row ordering doesn't update order of rows for datagrid with rows more than 10. #10459

Closed
2 tasks done
minchaej opened this issue Sep 25, 2023 · 9 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Reordering Related to the data grid Reordering feature support: commercial Support request from paid users

Comments

@minchaej
Copy link
Contributor

Order ID

I am a premium user but shouldn't this be a secret?

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

The problem in depth 🔍

Hi team MUI,

Screen Shot 2023-09-24 at 10 22 18 PM

As seen from above, I am using the Row ordering feature that is included in the premium plan. However, if the rows are more than 10, which exceeds the height of the datagrid, I have to use either scroll or hover to place the most bottom row to the most top row. As per the row ordering feature, if I let go of my left mouse button, the row ordering event should be fired thus reordering the rows, however, the row ordering does not work at all. Is there a way to fix this problem?

How to reproduce:

  1. Create a datagrid of fixed height like mine and have numerous rows.
  2. Use the drag and drop row ordering feature to bring bottom row to the top
  3. Doesn't update the reorder value, reordering event not fired.

Thank you so much!

Your environment 🌎

`npx @mui/envinfo`
On all env, safari, ie, chrome etc..
@minchaej minchaej added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: commercial Support request from paid users labels Sep 25, 2023
@MBilalShafi
Copy link
Member

MBilalShafi commented Sep 25, 2023

I couldn't manage to reproduce the problem, on this codesandbox fork of the official row reordering demo, I was able to reorder the rows and the onRowOrderChange callback fired whenever I tried to reorder a row.

reorder-example.mp4

Could you try forking the codesandbox example I linked above and see if you can reproduce the issue there? If yes, please do any sufficient changes to the codesandbox for the minimal reproduction and share them here along with the reproduction steps. This will help identify the problem and fix it better.

Thank You

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 25, 2023
@minchaej
Copy link
Contributor Author

@MBilalShafi Thank you so much for the reply! Absolutely, I will try it again and will let you know. Thanks!

@github-actions github-actions bot removed the status: waiting for author Issue with insufficient information label Sep 26, 2023
@romgrk romgrk added the status: waiting for author Issue with insufficient information label Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

The issue has been inactive for 7 days and has been automatically closed. If you think that it has been incorrectly closed, please reopen it and provide missing information (if any) or continue the last discussion.

@github-actions github-actions bot closed this as completed Oct 3, 2023
@minchaej
Copy link
Contributor Author

minchaej commented Oct 3, 2023

@MBilalShafi Thank you for your support. I have attached the video of the issue.
For this video, I have exactly copied your code on sandbox and executed on my local machine. So the code is 100% the same. The white theme is on safari, and the dark theme is on chrome.

As you can see, if I drag the bottom item to the top, the onChange event is not fired (no console log). Well, it DOES look like the orderings have changed on the UI, but since the onChange event is not fired, the order is not changed on the data level. as evident from firing the onChange event that brings the bottom item bottom again.

Could you please try to execute your code on a local machine? I can replicate this issue very consistently. Thank you!

mui-x-Issue-10459-Video.mp4

@github-actions github-actions bot removed the status: waiting for author Issue with insufficient information label Oct 3, 2023
@github-actions github-actions bot reopened this Oct 3, 2023
@minchaej
Copy link
Contributor Author

@MBilalShafi Can I get some support please? Thanks!

@MBilalShafi MBilalShafi added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 23, 2023
@cherniavskii
Copy link
Member

Hi @minchaej
The issue you're describing looks like a duplicate of #6165
The fix for it was released in https://github.com/mui/mui-x/releases/tag/v6.10.2
Which version of the data grid are you using?

@cherniavskii cherniavskii added status: waiting for author Issue with insufficient information feature: Reordering Related to the data grid Reordering feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 23, 2023
@minchaej
Copy link
Contributor Author

minchaej commented Oct 23, 2023

@cherniavskii I am using Next "version": "13.4.12". Isn't this pretty recent? That issue seems pretty old to me. Thanks!

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 23, 2023
@cherniavskii
Copy link
Member

@minchaej I meant the @mui/x-data-grid-premium package, which version are you using?

@cherniavskii cherniavskii added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 24, 2023
@minchaej
Copy link
Contributor Author

@cherniavskii Oops my bad! Got it, you are right, the issue is fixed in the update. Thanks for the support! I will close this issue as it is resolved now. Thanks again!

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 25, 2023
@cherniavskii cherniavskii removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Reordering Related to the data grid Reordering feature support: commercial Support request from paid users
Projects
None yet
Development

No branches or pull requests

4 participants