Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Documentation: logger, logLevel, icons props #1072

Closed
1 task done
emily-ellevation opened this issue Feb 17, 2021 · 3 comments
Closed
1 task done

[DataGrid] Documentation: logger, logLevel, icons props #1072

emily-ellevation opened this issue Feb 17, 2021 · 3 comments

Comments

@emily-ellevation
Copy link

Hello! I'm wondering about documentation/examples for the (free) DataGrid's logger, logLevel and icons props. For logging, I've tracked down this code but seems as though custom logger, logLevel would only be propagated via an options prop which is not in the official API docs (I've seen this prop in older SO posts so possible deprecated?). Also looking for clarity on the icons prop -- is this deprecated in favor of passing Icons via the components prop or is it something else altogether?

  • I have searched the issues of this repository and believe that this is not a duplicate.

Motivation 🔦

Making thorough DataGrid docs even better 👍
Thank you so much for any help and for the awesome work that you do.

@emily-ellevation emily-ellevation added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 17, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 18, 2021

Looking for clarity on the icons prop -- is this deprecated in favor of passing Icons via the components prop

@emily-ellevation Yes icons -> components.

logger, logLevel

Do you have a specific use case in mind? So far, I didn't document this feature when I wrote the first (/second) version of the documentation so:

  1. we can consider it private, allowing us to remove/refactor it without it being a breaking change or even mentioning it.
  2. forcing developers to come up with a solid problem that this feature could solve. Short of it, we can keep it internal for internal development use cases.

@oliviertassinari oliviertassinari added discussion and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 18, 2021
@emily-ellevation
Copy link
Author

emily-ellevation commented Feb 18, 2021

Thanks so much for a speedy reply!
Re:2nd point I was really just running through the API to spec out all of our potential options for functionality and trying to understand how I might use the logging props so definitely non-blocking for us and more of a documentation/visibility question. FWIW if uses cases are low and its largely private, I think hiding it from Docs is a good solution to avoid confusion 👍

@oliviertassinari
Copy link
Member

@emily-ellevation Oh ok, so it was simply asking for clarification. I'm closing for now then. Let's wait for developers asking for the feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants