Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @mui/internal-test-utils to devdepedencies. #13317

Closed
1 task done
Matt-Butler opened this issue May 30, 2024 · 7 comments · Fixed by #13318
Closed
1 task done

Move @mui/internal-test-utils to devdepedencies. #13317

Matt-Butler opened this issue May 30, 2024 · 7 comments · Fixed by #13318
Assignees
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes

Comments

@Matt-Butler
Copy link

Matt-Butler commented May 30, 2024

Search keywords

@mui/internal-test-utils

Latest version

  • I have tested the latest version

Steps to reproduce

[Link to live example: (required)

Steps:
](

"@mui/internal-test-utils": "1.0.0-dev.20240529-082515-213b5e33ab",
)

Current behavior

Installing this package, requires updating the version of my test utils.

Expected behavior

Installing this package has no impact on the version of my test utils.

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID or Support key 💳 (optional)

No response

@Matt-Butler Matt-Butler added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 30, 2024
@LukasTy
Copy link
Member

LukasTy commented May 30, 2024

Thank you for reporting it! 🙏
I'm very sorry that this mistake has slipped through the code review, it's only the @mui/x-data-grid package, which has this dependency listed in the regular dependencies list rather than devDependencies. 🙈

@LukasTy LukasTy added bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 30, 2024
@LukasTy LukasTy self-assigned this May 30, 2024
@Matt-Butler
Copy link
Author

Thanks for the quick response, I appreciate it!

@LukasTy
Copy link
Member

LukasTy commented May 30, 2024

@Matt-Butler is it a blocking problem for you or waiting for next week's (next Thursday) regular release is a viable option? 🤔

Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@Matt-Butler: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@LukasTy
Copy link
Member

LukasTy commented May 31, 2024

@Matt-Butler A fixed package (v7.6.1) has been released: https://www.npmjs.com/package/@mui/x-data-grid?activeTab=versions

@Matt-Butler
Copy link
Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants