Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] MUI DateRangePicker property "name" doesnt render #13818

Closed
JoseFerDiverger opened this issue Jul 12, 2024 · 3 comments · Fixed by #13821
Closed

[pickers] MUI DateRangePicker property "name" doesnt render #13818

JoseFerDiverger opened this issue Jul 12, 2024 · 3 comments · Fixed by #13821
Assignees
@LukasTy
Labels
component: DateRangePicker The React component. component: pickers This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user regression A bug, but worse

Comments

@JoseFerDiverger
Copy link

JoseFerDiverger commented Jul 12, 2024 •
edited by github-actions bot
Loading

Steps to reproduce

Link to live example: Example

Steps:

  1. Add DateRangePicker with "name" parameter to react code
image

  1. Open browser javascript console

  2. Check that parameter "name" doesnt exist in that component

image

This parameter exist in the api documentation and its used on our project, so with last update it was broken
image

Current behavior

Can't get component by name

Expected behavior

No response

Context

No response

Your environment

Production

Search keywords: daterangepicker

Search keywords:
@JoseFerDiverger JoseFerDiverger added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 12, 2024
@zannager zannager transferred this issue from mui/material-ui Jul 12, 2024
@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Jul 12, 2024
@LukasTy LukasTy self-assigned this Jul 12, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 12, 2024

@JoseFerDiverger Thank you for reporting this problem! 🙏
The issue has been introduced with v7.0.0-beta.4.
Looking for the cause.

@LukasTy LukasTy added regression A bug, but worse plan: Pro Impact at least one Pro user and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 12, 2024
@LukasTy LukasTy changed the title MUI DateRangePicker property "name" doesnt render [pickers] MUI DateRangePicker property "name" doesnt render Jul 12, 2024
@LukasTy LukasTy added the component: DateRangePicker The React component. label Jul 12, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 12, 2024

Here is the regression cause: https://github.com/mui/mui-x/pull/10649/files#diff-51686a4d64819c7725f329d4c9c06225ad0bc5345ce97d24ed3df8976433aa07L156.

@LukasTy LukasTy mentioned this issue Jul 12, 2024
Merged
@github-actions GitHub Actions
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@JoseFerDiverger: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasTy LukasTy

Labels
component: DateRangePicker The React component. component: pickers This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DateRangePicker] Fix name prop propagation regression LukasTy/mui-x
3 participants
@LukasTy @zannager @JoseFerDiverger