-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Audio Player/Waveform component #13883
Labels
Comments
TheOneTheOnlyJJ
added
the
status: waiting for maintainer
These issues haven't been looked at yet by a maintainer
label
Jul 18, 2024
michelengelen
added
new feature
New feature or request
waiting for 👍
Waiting for upvotes
and removed
status: waiting for maintainer
These issues haven't been looked at yet by a maintainer
labels
Jul 18, 2024
oliviertassinari
changed the title
Add an Audio Player/Waveform component
Add Audio Player/Waveform component
Jul 21, 2024
I'm closing to signal that it's unlikely. Still, the "waiting for upvotes" label is still applied, so up for considerations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Along the lines of #13196, right now the only way to play audio in a MUI interface is to use the default HTML
<audio>
element, which does not conform to the Material Design guidelines. While the official MD3 docs do not cover audio players, nor are there any potential examples for us to base a component on, we could extrapolate from what I found in the docs regarding video players (#13196).Examples
Conforming to Material Design:
Others:
Motivation
In my app, I want to play both video (so I opened #13196) and audio (so I'm opening this).
I would like to have an audio player component that conforms to Material Design (especially MD3 once that lands).
Besides the default HTML
<audio>
element features, the following should also be supported:...and, last but not least, the cherry on the cake...
Examples:
This could be done by integrating wavesurfer.js (maybe through wavesurfer-react) in the component. However, given that these waveforms can be styled extensively, it may be more appropriate to leverage Pigment CSS for better integration in the MUI environment. This would very likely require writing the waveform generator code from scratch. The complexities of this may require breaking the audio progress indicator down into its own separate component. Maybe code from the Charts components could be reused here to a great extent.
Writing such a waveform generator from scratch would also allow for the inclusion of functionalities provided by some of the wavesurfer.js plugins in the default implementation, and make their visuals conform to Material Design as well. The plugins that could be incorporated like this are: Regions, Hover, Envelope, Minimap and Timeline.
Having these features would make Material UI to be more accessible to music mixing/composing applications.
Search keywords: audio player players sound music wave form waveform
The text was updated successfully, but these errors were encountered: