Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Use selectors on TreeItem instead of instance methods #14200

Closed
flaviendelangle opened this issue Aug 14, 2024 · 1 comment
Closed

[TreeView] Use selectors on TreeItem instead of instance methods #14200

flaviendelangle opened this issue Aug 14, 2024 · 1 comment
Assignees
@flaviendelangle
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! performance

Comments

@flaviendelangle
Copy link
Member

flaviendelangle commented Aug 14, 2024 •
edited
Loading

Follow up on #13520

The main goal here is to stop re-rendering all the items on every render of the tree view component.
For this, we need to stop using instance methods in the render.

Most of those should be replaceable by selectors.
Those should use the same architecture as useGridSelector with an internal state at the item level.

Selectors could also be used at the tree view level but I don't think we have use cases for now.

Search keywords:
@flaviendelangle flaviendelangle added performance component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Aug 14, 2024
@flaviendelangle flaviendelangle changed the title [TreeView] Add selectors [TreeView] Use selectors on TreeItem instead of instance methods Aug 14, 2024
@flaviendelangle flaviendelangle mentioned this issue Sep 5, 2024
Merged
18 tasks
@flaviendelangle flaviendelangle self-assigned this Nov 22, 2024
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flaviendelangle